Guard MergeNB against merge.tool=nbdime and provide terminal-ready remediation#85
Draft
Guard MergeNB against merge.tool=nbdime and provide terminal-ready remediation#85
merge.tool=nbdime and provide terminal-ready remediation#85Conversation
Co-authored-by: Avni2000 <77120766+Avni2000@users.noreply.github.com>
Co-authored-by: Avni2000 <77120766+Avni2000@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add check for mergetool in gitIntegration.ts
Guard MergeNB against Feb 13, 2026
merge.tool=nbdime and provide terminal-ready remediation
Owner
|
Some intricacies the AI's not aware of -
|
Owner
|
We should also make a proper test for this, since I know for a fact it'll be the source of a lot of complaints |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MergeNB currently cannot safely operate in the same merge flow when Git is configured with
merge.tool=nbdime. This PR adds an explicit compatibility check and gives users copy/paste terminal guidance to disable that configuration before resolving notebook conflicts.Activation-time compatibility guard
ensureSupportedMergeTool(...)ingitIntegration.ts.git config --get merge.toolfor the active repo and detectsnbdime.UnsupportedMergeToolError.User-facing remediation path
nbdimeis detected.merge.tool, removemergetool.nbdimeconfig, and optionally uninstallnbdime.Early wiring in extension lifecycle
activate(...)inextension.tsso users are notified immediately, before entering MergeNB conflict resolution flow.Implementation details
Set) to avoid repeated warnings in the same workspace.merge.tool(expectedgit config --getexit behavior).Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
update.code.visualstudio.com/home/REDACTED/work/_temp/ghcca-node/node/bin/node node out/tests/runIntegrationTest.js --test takeAll_base(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.